linux-kernel - Re: [PATCH] perf/script: allow --symbol to accept hexadecimal addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200331191128.GL9917@kernel.org>
Date:   Tue, 31 Mar 2020 16:11:28 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf/script: allow --symbol to accept hexadecimal
 addresses

Em Wed, Mar 25, 2020 at 03:08:02PM -0700, Ian Rogers escreveu:
> From: Stephane Eranian <eranian@...gle.com>
> 
> This patch extends the perf script --symbols option to filter
> on hexadecimal addresses in addition to symbol names. This makes
> it easier to handle cases where symbols are aliased.
> 
> With this patch, it is possible to mix and match symbols and hexadecimal
> addresses using the --symbols option.
> 
> $ perf script --symbols=noploop,0x4007a0

Applied, can you please send a followup patch to the man page stating
that this is supported?

Thanks,

- Arnaldo
 
> Reviewed-by: Ian Rogers <irogers@...gle.com>
> Signed-off-by: Stephane Eranian <eranian@...gle.com>
> ---
>  tools/perf/util/event.c | 21 +++++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index c5447ff516a2..c978a73fe475 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -599,10 +599,23 @@ int machine__resolve(struct machine *machine, struct addr_location *al,
>  		al->sym = map__find_symbol(al->map, al->addr);
>  	}
>  
> -	if (symbol_conf.sym_list &&
> -		(!al->sym || !strlist__has_entry(symbol_conf.sym_list,
> -						al->sym->name))) {
> -		al->filtered |= (1 << HIST_FILTER__SYMBOL);
> +	if (symbol_conf.sym_list) {
> +		int ret = 0;
> +		char al_addr_str[32];
> +		size_t sz = sizeof(al_addr_str);
> +
> +		if (al->sym) {
> +			ret = strlist__has_entry(symbol_conf.sym_list,
> +						al->sym->name);
> +		}
> +		if (!(ret && al->sym)) {
> +			snprintf(al_addr_str, sz, "0x%"PRIx64,
> +				al->map->unmap_ip(al->map, al->sym->start));
> +			ret = strlist__has_entry(symbol_conf.sym_list,
> +						al_addr_str);
> +		}
> +		if (!ret)
> +			al->filtered |= (1 << HIST_FILTER__SYMBOL);
>  	}
>  
>  	return 0;
> -- 
> 2.25.1.696.g5e7596f4ac-goog
> 

-- 

- Arnaldo