linux-kernel - Re: [PATCH 5.6 00/23] 5.6.1-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200331192949.GN9917@kernel.org>
Date:   Tue, 31 Mar 2020 16:29:49 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        lkft-triage@...ts.linaro.org,
        linux- stable <stable@...r.kernel.org>,
        Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Subject: Re: [PATCH 5.6 00/23] 5.6.1-rc1 review

Em Tue, Mar 31, 2020 at 11:20:37AM -0700, Linus Torvalds escreveu:
> On Tue, Mar 31, 2020 at 11:08 AM Naresh Kamboju
> <naresh.kamboju@...aro.org> wrote:
> >
> > Perf build broken on Linux next and mainline and now on stable-rc-5.6 branch.
> 
> Strange. What is it that triggers the problem for you? It works fine
> here.. The error looks like some kind of command line quoting error,
> but I don't see the direct cause.
> 
> Have you bisected the failure? Build failures should be particularly
> easy and quick to bisect.

Naresh, can you try with the patch below? There was some back and forth
about a second patch in a series and this fell thru the cracks.

And also, BTW, can you please send me instructions on how to get hold of
the toolchain you use to crossbuild perf, so that I can add it to my set
of test build containers?

- Arnaldo

---

From: He Zhe <zhe.he@...driver.com>

The $(CC) passed to arch_errno_names.sh may include a series of parameters
along with gcc itself. To avoid overwriting the following parameters of
arch_errno_names.sh and break the build like below, we just pick up the
first word of the $(CC).

find: unknown predicate `-m64/arch'
x86_64-wrs-linux-gcc: warning: '-x c' after last input file has no effect
x86_64-wrs-linux-gcc: error: unrecognized command line option '-m64/include/uapi/asm-generic/errno.h'
x86_64-wrs-linux-gcc: fatal error: no input files

Signed-off-by: He Zhe <zhe.he@...driver.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 3eda9d4..7114c11 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -573,7 +573,7 @@ arch_errno_hdr_dir := $(srctree)/tools
 arch_errno_tbl := $(srctree)/tools/perf/trace/beauty/arch_errno_names.sh
 
 $(arch_errno_name_array): $(arch_errno_tbl)
-	$(Q)$(SHELL) '$(arch_errno_tbl)' $(CC) $(arch_errno_hdr_dir) > $@
+	$(Q)$(SHELL) '$(arch_errno_tbl)' $(firstword $(CC)) $(arch_errno_hdr_dir) > $@
 
 sync_file_range_arrays := $(beauty_outdir)/sync_file_range_arrays.c
 sync_file_range_tbls := $(srctree)/tools/perf/trace/beauty/sync_file_range.sh
-- 
2.7.4