[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPcyv4i=vyAFiAkGRaRx=+fnGOq9Eebo8szobBDD2AZ+vy877A@mail.gmail.com>
Date: Tue, 31 Mar 2020 12:42:28 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: Vishal L Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
"Weiny, Ira" <ira.weiny@...el.com>,
"Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
jmoyer <jmoyer@...hat.com>,
linux-nvdimm <linux-nvdimm@...ts.01.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 -next] libnvdimm/region: Fix build error
On Tue, Mar 31, 2020 at 4:52 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> On CONFIG_PPC32=y build fails:
>
> drivers/nvdimm/region_devs.c:1034:14: note: in expansion of macro ‘do_div’
> remainder = do_div(per_mapping, mappings);
> ^~~~~~
> In file included from ./arch/powerpc/include/generated/asm/div64.h:1:0,
> from ./include/linux/kernel.h:18,
> from ./include/asm-generic/bug.h:19,
> from ./arch/powerpc/include/asm/bug.h:109,
> from ./include/linux/bug.h:5,
> from ./include/linux/scatterlist.h:7,
> from drivers/nvdimm/region_devs.c:5:
> ./include/asm-generic/div64.h:243:22: error: passing argument 1 of ‘__div64_32’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> __rem = __div64_32(&(n), __base); \
>
> Use div_u64 instead of do_div to fix this.
>
> Fixes: 2522afb86a8c ("libnvdimm/region: Introduce an 'align' attribute")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: use div_u64_rem and code cleanup
Looks good now, thanks, applied.
Powered by blists - more mailing lists