linux-kernel - Re: [PATCH v2] ARM: dts: am5729: beaglebone-ai: adding device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4M_BxY0JgWXRRp48gFgWWcN2uJd7q4kXOCmOBziGpWYCvoA@mail.gmail.com>
Date:   Tue, 31 Mar 2020 22:30:30 +0200
From:   Drew Fustini <pdp7pdp7@...il.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Grygorii Strashko <grygorii.strashko@...com>,
        Caleb Robey <c-robey@...com>, linux-omap@...r.kernel.org,
        Jason Kridner <jkridner@...il.com>,
        Lokesh Vutla <lokeshvutla@...com>, Jason Kridner <jdk@...com>,
        Faiz Abbas <faiz_abbas@...com>,
        Andreas Dannenberg <dannenberg@...com>,
        Jean-Jacques Hiblot <jjhiblot@...com>,
        Praneeth Bajjuri <praneeth@...com>,
        "Andrew F . Davis" <afd@...com>, Tom Rini <trini@...sulko.com>,
        Robert Nelson <robertcnelson@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Drew Fustini <drew@...gleboard.org>
Subject: Re: [PATCH v2] ARM: dts: am5729: beaglebone-ai: adding device tree

On Tue, Mar 31, 2020 at 8:46 PM Tony Lindgren <tony@...mide.com> wrote:
>
> * Drew Fustini <pdp7pdp7@...il.com> [200331 18:39]:
> > On Thu, Dec 12, 2019 at 6:06 PM Tony Lindgren <tony@...mide.com> wrote:
> > > > On 21/11/2019 00:05, Caleb Robey wrote:
> > > > > From: Jason Kridner <jdk@...com>
> > > > >
> > > > > BeagleBoard.org BeagleBone AI is an open source hardware single
> > > > > board computer based on the Texas Instruments AM5729 SoC featuring
> > > > > dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital
> > > > > signal processor (DSP), quad-core embedded vision engine (EVE),
> > > > > Arm Cortex-M4 processors, dual programmable realtime unit
> > > > > industrial control subsystems and more. The board features 1GB
> > > > > DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash,
> > > > > 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion
> > > > > headers.
> > > > >
> > > > > For more information, refer to:
> > > > > https://beaglebone.ai
> > > > >
> > > > > This patch introduces the BeagleBone AI device tree.
> > > > >
> > > > > Note that the device use the "ti,tpd12s016" component which is
> > > > > software compatible with "ti,tpd12s015". Thus we only use the
> > > > > latter driver.
> > > >
> > > > Ah. thanks. I see my comments resolved here.
> > > > no more comments to net part from my side.
> > >
> > > Just FYI, Jason had one pending comment on the earlier version
> > > about the compatible property to use.
> > >
> > > So I'm assuming there will be a new version posted, tagging
> > > this one as read.
> >
> > It came to my attention today when talking with Jason Kridner and
> > Robert Nelson that we did not get the BeagleBone AI device tree
> > upstream yet.
> >
> > I am having trouble identifying what the pending comment was from the
> > original patch series.
> >
> > Was it related to this compatible string?
> >
> > > +       compatible = "beagleboard.org,am5729-beagleboneai", "ti,am5728",
>
> Yes I think Jason had some comment on the compatible string
> to use.

Ah, I see it now [1]:

> Probably need to change "beagleboard.org," to "beagle," as of today.
> With the new yaml stuff for defining device tree entries, having the
> period (.) in the vendor identifier can be a bit confusing. I altered
> my submission to avoid this.

so I think this should work:

compatible = "beagleboard-org,am5729-beagleboneai", "ti,am5728",

We'll get it resubmitted.

Thanks,
Drew

[1] https://lore.kernel.org/linux-devicetree/CA+T6QPm-DNG_QoAMWw_zUDUkZCfhbBTgygnoPAykf3mgK7opaA@mail.gmail.com/