linux-kernel - Re: [PATCH 5.5 102/170] scripts/dtc: Remove redundant YYLOC global declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8020A90C-7DEE-40DF-86F6-4446DE144BAA@suse.com>
Date:   Tue, 31 Mar 2020 23:35:38 +0200
From:   Dirk Müller <dmueller@...e.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Nathan Chancellor <natechancellor@...il.com>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        David Gibson <david@...son.dropbear.id.au>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 5.5 102/170] scripts/dtc: Remove redundant YYLOC global
 declaration

Hi Greg,

>> However I think the sed above on the *patch* means that the patch will *only* modify the generated sources, not the input sources. I think
>> it would be better to patch both *input* and *generated* sources, or backport the generate-at-runtime patch as well (which might be
>> even further outside the stable policy). 
> 
> What do you mean by "input sources" here?

scripts/dtc/update-dtc-source.sh in older kernel generates a _shipped variant of the files from the .l/.y files:

$ ls -1 scripts/dtc/dtc-lexer.l*
scripts/dtc/dtc-lexer.l
scripts/dtc/dtc-lexer.lex.c_shipped

in newer kernels these _shipped files are generated at build time from dtc-lexer.l, which my patch is updating. I suggested
to modify the patches for older release to *both* patch dtc-lexer.l as well as update the *generated* files that are tracked
in git as dtc-lexer.lex.c_shipped rather than just in/place modifying the generated file (which would then at some later point
in time get lost as other changes regenerate the _shipped file then, reintroducing the bug). 

> If I drop it for now, I'll have to add it back when gcc10 is pushed out
> to my build systems and laptops :(

Let me know if I can help with a backportable patch. 

Greetings,
Dirk