linux-kernel - Re: [PATCH] clocksource: Add debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lfnguqky.fsf@nanos.tec.linutronix.de>
Date:   Wed, 01 Apr 2020 00:06:37 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Thierry Reding <thierry.reding@...il.com>,
        John Stultz <john.stultz@...aro.org>
Cc:     Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: Add debugfs support

Thierry,

Thierry Reding <thierry.reding@...il.com> writes:
> Add a top-level "clocksource" directory to debugfs. For each clocksource
> registered with the system, a subdirectory will be added with attributes
> that can be queried to obtain information about the clocksource.

first of all this does tell what this patch does but omits the more
important information about the WHY.

What's even worse is that the changelog is blantantly wrong.

> +static int clocksource_debugfs_counter_show(struct seq_file *s, void *data)
> +{
> +	struct clocksource *cs = s->private;
> +
> +	seq_printf(s, "%llu\n", cs->read(cs));
> +
> +	return 0;
> +}
> +DEFINE_SHOW_ATTRIBUTE(clocksource_debugfs_counter);
> +
> +static void clocksource_debugfs_add(struct clocksource *cs)
> +{
> +	if (!debugfs_root)
> +		return;
> +
> +	cs->debugfs = debugfs_create_dir(cs->name, debugfs_root);
> +
> +	debugfs_create_file("counter", 0444, cs->debugfs, cs,
> +			    &clocksource_debugfs_counter_fops);
> +}

It does not provide any information about the clocksource, it provides
an interface to read the counter - nothing else.

Try again.

Thanks,

        tglx