linux-kernel - Re: [PATCH] driver core: Use dev_warn() instead of dev_WARN() for deferred_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+G9fYv7XRm2ObuBQQy=iiOAj6rj_JX=8PBTt53JtDBwe5W=_Q@mail.gmail.com>
Date:   Tue, 31 Mar 2020 12:24:17 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Robin Murphy <robin.murphy@....com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Basil Eljuse <Basil.Eljuse@....com>,
        Ferry Toth <fntoth@...il.com>, Arnd Bergmann <arnd@...db.de>,
        Anders Roxell <anders.roxell@...aro.org>
Subject: Re: [PATCH] driver core: Use dev_warn() instead of dev_WARN() for
 deferred_probe_timeout warnings

On Tue, 31 Mar 2020 at 01:57, John Stultz <john.stultz@...aro.org> wrote:
>
> In commit c8c43cee29f6 ("driver core: Fix
> driver_deferred_probe_check_state() logic") and following
> changes the logic was changes slightly so that if there is no
> driver to match whats found in the dtb, we wait 30 seconds
> for modules to be loaded by userland, and then timeout, where
> as previously we'd print "ignoring dependency for device,
> assuming no driver" and immediately return -ENODEV after
> initcall_done.
>
> However, in the timeout case (which previously existed but was
> practicaly un-used without a boot argument), the timeout message
> uses dev_WARN(). This means folks are now seeing a big backtrace
> in their boot logs if there a entry in their dts that doesn't
> have a driver.
>
> To fix this, lets use dev_warn(), instead of dev_WARN() to match
> the previous error path.
>
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Sudeep Holla <sudeep.holla@....com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Naresh Kamboju <naresh.kamboju@...aro.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Basil Eljuse <Basil.Eljuse@....com>
> Cc: Ferry Toth <fntoth@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Anders Roxell <anders.roxell@...aro.org>
> Fixes: c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state() logic")
> Signed-off-by: John Stultz <john.stultz@...aro.org>

Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>

I have applied this patch and tested.
The reported problem is fixed by patch on arm64 Juno-r2 device.
https://lkft.validation.linaro.org/scheduler/job/1323860#L556

- Naresh