linux-kernel - Re: [PATCH v8] staging: vt6656: add error code handling to unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200331082952.GA13403@jiffies>
Date:   Tue, 31 Mar 2020 09:29:52 +0100
From:   Quentin Deslandes <quentin.deslandes@...ev.co.uk>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     "John B. Wyatt IV" <jbwyatt4@...il.com>,
        outreachy-kernel@...glegroups.com,
        Julia Lawall <julia.lawall@...ia.fr>,
        Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Colin Ian King <colin.king@...onical.com>,
        Malcolm Priestley <tvboxspy@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8] staging: vt6656: add error code handling to unused
 variable

On 03/31/20 02:01:03, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 16:39:00 -0700
> "John B. Wyatt IV" <jbwyatt4@...il.com> wrote:
> 
> > Add error code handling to unused 'ret' variable that was never used.
> > Return an error code from functions called within vnt_radio_power_on.
> > 
> > Issue reported by coccinelle (coccicheck).
> > 
> > Suggested-by: Quentin Deslandes <quentin.deslandes@...ev.co.uk>
> > Suggested-by: Stefano Brivio <sbrivio@...hat.com>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes@...ev.co.uk>
>   ^ This should be dropped unless Quentin agrees to this version as well
> 
> > Signed-off-by: John B. Wyatt IV <jbwyatt4@...il.com>
> 
> Reviewed-by: Stefano Brivio <sbrivio@...hat.com>
> 
> -- 
> Stefano
> 

Just reviewed it so John doesn't need to send a v9. Everything seems
good, I'm happy and checkpatch is too.

Reviewed-by: Quentin Deslandes <quentin.deslandes@...ev.co.uk>

Thanks,
Quentin