linux-kernel - Re: linux-next: manual merge of the pci tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Mar 2020 10:37:45 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: linux-next: manual merge of the pci tree with Linus' tree

On Tue, Mar 31, 2020 at 1:52 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> Today's linux-next merge of the pci tree got a conflict in:
>
>   drivers/net/ethernet/intel/ice/ice_main.c
>
> between commit:
>
>   19cce2c6f6dc ("ice: Make print statements more compact")

FWIW, that doesn't really look like an improvement to me, as the long
lines are now broken by my editor, making them harder to read...

>
> from Linus' tree and commit:
>
>   894020fdd88c ("PCI/AER: Rationalize error status register clearing")
>
> from the pci tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc drivers/net/ethernet/intel/ice/ice_main.c
> index 5ef28052c0f8,effca3fa92e0..000000000000
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@@ -3458,9 -3495,10 +3458,9 @@@ static pci_ers_result_t ice_pci_err_slo
>                         result = PCI_ERS_RESULT_DISCONNECT;
>         }
>
> -       err = pci_cleanup_aer_uncorrect_error_status(pdev);
> +       err = pci_aer_clear_nonfatal_status(pdev);
>         if (err)
> -               dev_dbg(&pdev->dev, "pci_cleanup_aer_uncorrect_error_status failed, error %d\n",
>  -              dev_dbg(&pdev->dev,
>  -                      "pci_aer_clear_nonfatal_status() failed, error %d\n",
> ++              dev_dbg(&pdev->dev, "pci_aer_clear_nonfatal_status() failed, error %d\n",
>                         err);
>                 /* non-fatal, continue */

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds