[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87pnctuyq3.fsf@mpe.ellerman.id.au>
Date: Tue, 31 Mar 2020 11:58:28 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: YueHaibing <yuehaibing@...wei.com>, mporter@...nel.crashing.org,
benh@...nel.crashing.org, paulus@...ba.org
Cc: alistair@...ple.id.au, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH] powerpc/44x: Make AKEBONO depends on NET
YueHaibing <yuehaibing@...wei.com> writes:
> Fix Kconfig warnings:
>
> WARNING: unmet direct dependencies detected for NETDEVICES
> Depends on [n]: NET [=n]
> Selected by [y]:
> - AKEBONO [=y] && PPC_47x [=y]
>
> WARNING: unmet direct dependencies detected for ETHERNET
> Depends on [n]: NETDEVICES [=y] && NET [=n]
> Selected by [y]:
> - AKEBONO [=y] && PPC_47x [=y]
>
> AKEBONO select NETDEVICES and ETHERNET unconditionally,
It shouldn't do that, that's the job of a defconfig.
It might want to enable NET_VENDOR_IBM iff the config already has NET
and other dependencies enabled.
So the patch below might work?
cheers
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 25ebe634a661..32aac4f40f1b 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -207,9 +207,7 @@ config AKEBONO
select PPC4xx_HSTA_MSI
select I2C
select I2C_IBM_IIC
- select NETDEVICES
- select ETHERNET
- select NET_VENDOR_IBM
+ imply NET_VENDOR_IBM
select IBM_EMAC_EMAC4 if IBM_EMAC
select USB if USB_SUPPORT
select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> If NET is not set, build fails. Add this dependcy to fix this.
>
> Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> arch/powerpc/platforms/44x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index 25ebe634a661..394f662d7df2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -199,6 +199,7 @@ config FSP2
> config AKEBONO
> bool "IBM Akebono (476gtr) Support"
> depends on PPC_47x
> + depends on NET
> select SWIOTLB
> select 476FPE
> select PPC4xx_PCI_EXPRESS
> --
> 2.17.1
Powered by blists - more mailing lists