linux-kernel - Re: [PATCH net-next] hv_netvsc: Remove unnecessary round_up for recv_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200330.194424.1566124309061632230.davem@davemloft.net>
Date:   Mon, 30 Mar 2020 19:44:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com
Cc:     sashal@...nel.org, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] hv_netvsc: Remove unnecessary round_up for
 recv_completion_cnt

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Mon, 30 Mar 2020 12:29:13 -0700

> The vzalloc_node(), already rounds the total size to whole pages, and
> sizeof(u64) is smaller than sizeof(struct recv_comp_data). So
> round_up of recv_completion_cnt is not necessary, and may cause extra
> memory allocation.
> 
> To save memory, remove this unnecessary round_up for recv_completion_cnt.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied, thanks.