linux-kernel - [PATCH v4 3/7] tpm: tpm_tis: rewrite "tpm_tis_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200331113207.107080-4-amirmizi6@gmail.com>
Date:   Tue, 31 Mar 2020 14:32:03 +0300
From:   <amirmizi6@...il.com>
To:     <Eyal.Cohen@...oton.com>, <jarkko.sakkinen@...ux.intel.com>,
        <oshrialkoby85@...il.com>, <alexander.steffen@...ineon.com>,
        <robh+dt@...nel.org>, <mark.rutland@....com>, <peterhuewe@....de>,
        <jgg@...pe.ca>, <arnd@...db.de>, <gregkh@...uxfoundation.org>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-integrity@...r.kernel.org>, <oshri.alkoby@...oton.com>,
        <tmaimon77@...il.com>, <gcwilson@...ibm.com>,
        <kgoldman@...ibm.com>, <Dan.Morav@...oton.com>,
        <oren.tanami@...oton.com>, <shmulik.hager@...oton.com>,
        <amir.mizinski@...oton.com>, Amir Mizinski <amirmizi6@...il.com>
Subject: [PATCH v4 3/7] tpm: tpm_tis: rewrite "tpm_tis_req_canceled()"

From: Amir Mizinski <amirmizi6@...il.com>

Using this function while read/write data resulted in aborted operation.
After investigating according to TCG TPM Profile (PTP) Specifications,
i found cancel should happen only if TPM_STS.commandReady bit is lit and
couldn't find a case when the current condition is valid.
Also only cmdReady bit need to be compared instead of the full lower status
register byte.

Signed-off-by: Amir Mizinski <amirmizi6@...il.com>
---
 drivers/char/tpm/tpm_tis_core.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 6c4f232..18b9dc4 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -710,17 +710,7 @@ static int probe_itpm(struct tpm_chip *chip)

 static bool tpm_tis_req_canceled(struct tpm_chip *chip, u8 status)
 {
-       struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
-
-       switch (priv->manufacturer_id) {
-       case TPM_VID_WINBOND:
-               return ((status == TPM_STS_VALID) ||
-                       (status == (TPM_STS_VALID | TPM_STS_COMMAND_READY)));
-       case TPM_VID_STM:
-               return (status == (TPM_STS_VALID | TPM_STS_COMMAND_READY));
-       default:
-               return (status == TPM_STS_COMMAND_READY);
-       }
+       return ((status & TPM_STS_COMMAND_READY) == TPM_STS_COMMAND_READY);
 }

 static irqreturn_t tis_int_handler(int dummy, void *dev_id)
--
2.7.4

===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.