linux-kernel - Re: [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e832e62.1c69fb81.2a0e9.b85d@mx.google.com>
Date:   Tue, 31 Mar 2020 17:19:51 +0530
From:   Rohit Sarkar <rohitsarkar5398@...il.com>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     "Sa, Nuno" <Nuno.Sa@...log.com>,
        "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "stefan.popa@...log.com" <stefan.popa@...log.com>,
        "zhongjiang@...wei.com" <zhongjiang@...wei.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "knaack.h@....de" <knaack.h@....de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of
 DEFINE_SIMPLE_ATTRIBUTE

Hey Nuno,
> > > > 
> > > I don't have the exact parts that this patch is touching but I have other parts where this patch
> > > applies and should be same. So, the idea to test this is to read the files in debugfs? Maybe also
> > > some unbind + binding?
> > > 
> > > I will try to test this still today...
> > 
> > The stress test is to open the debugfs file, then unbind the device and then
> > read from the still open debugfs file.
> Yes, also just to be sure, we need to test DEFINE_DEBUGFS_ATTRIBUTE
> along with debugfs_create_file_unsafe. I will send out another patch
> that changes debugfs_create_file to debugfs_create_file_unsafe and then
> that can be tested.
Have sent out a v2 that is ready to be tested
> > - Lars
> 
> Thanks,
> Rohit
Thanks,
Rohit