linux-kernel - Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Mar 2020 15:09:33 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>,
        Rob Herring <robh+dt@...nel.org>, mark.rutland@....com,
        Stenkin Evgeniy <stenkinevgeniy@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2

Cc: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>

Hi Marek,

Le mar. 31 mars 2020 à 7:36, Marek Szyprowski 
<m.szyprowski@...sung.com> a écrit :
> Hi Paul,
> 
> On 2020-03-18 15:25, Paul Cercueil wrote:
>>>>   +    };
>>>>   +
>>>>   +    tsp_reg: regulator-1 {
>>>>   +        compatible = "regulator-fixed";
>>>>   +        regulator-name = "TSP_FIXED_VOLTAGES";
>>>>   +        regulator-min-microvolt = <3300000>;
>>>>   +        regulator-max-microvolt = <3300000>;
>>>>   +        gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>;
>>>>   +        startup-delay-us = <70000>;
>>>>   +        enable-active-high;
>>>>   +        regulator-boot-on;
>>>>   +        regulator-always-on;
>>> 
>>>  always-on and boot-on should not be needed. You have a consumer 
>>> for this
>>>  regulator.
>> 
>>  About this: the touchscreen driver does not use a regulator, so I
>>  believe that's why these properties were here.
>> 
>>  I sent patches upstream to address the issue:
>>  https://lkml.org/lkml/2020/3/15/94
>> 
>>  I believe this means I cannot merge the i9100 devicetree until it is
>>  acked.
> 
> One more information - similar change has been already posted, but it
> looks it got lost then: https://patchwork.kernel.org/patch/10550903/

I was aware of this patch, but didn't know it was sent upstream.

This other patch uses two regulators, vdd/avdd but doesn't give any 
reason why.

Paweł, is that really needed?

-Paul


> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>