linux-kernel - Re: [PATCH] leds: core: Fix warning message when init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef851b8f-0232-ab09-482e-ae575fb8dbde@gmail.com>
Date:   Wed, 1 Apr 2020 21:49:00 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Ricardo Ribalda Delgado <ribalda@...nel.org>,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: core: Fix warning message when init_data

Hi Ricardo,

Thank you for the patch.

On 4/1/20 11:51 AM, Ricardo Ribalda Delgado wrote:
> The warning message when a led is renamed due to name collition can fail
> to show proper original name if init_data is used. Eg:
> 
> [    9.073996] leds-gpio a0040000.leds_0: Led (null) renamed to red_led_1 due to name collision
> 
> Fixes: bb4e9af0348d ("leds: core: Add support for composing LED class device names")
> Signed-off-by: Ricardo Ribalda Delgado <ribalda@...nel.org>
> ---
>  drivers/leds/led-class.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 1fc40e8af75e..3363a6551a70 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -376,7 +376,7 @@ int led_classdev_register_ext(struct device *parent,
>  
>  	if (ret)
>  		dev_warn(parent, "Led %s renamed to %s due to name collision",
> -				led_cdev->name, dev_name(led_cdev->dev));
> +				proposed_name, dev_name(led_cdev->dev));
>  
>  	if (led_cdev->flags & LED_BRIGHT_HW_CHANGED) {
>  		ret = led_add_brightness_hw_changed(led_cdev);
> 

Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>

-- 
Best regards,
Jacek Anaszewski