linux-kernel - RE: [PATCH v4 2/7] tpm: tpm_tis: Add check_data handle to tpm_tis_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173e4e392b9648b7afeb09680d8073b5@SFHDAG3NODE3.st.com>
Date:   Wed, 1 Apr 2020 20:18:14 +0000
From:   Benoit HOUYERE <benoit.houyere@...com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        "amirmizi6@...il.com" <amirmizi6@...il.com>
CC:     "Eyal.Cohen@...oton.com" <Eyal.Cohen@...oton.com>,
        "oshrialkoby85@...il.com" <oshrialkoby85@...il.com>,
        "alexander.steffen@...ineon.com" <alexander.steffen@...ineon.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "peterhuewe@....de" <peterhuewe@....de>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "oshri.alkoby@...oton.com" <oshri.alkoby@...oton.com>,
        "tmaimon77@...il.com" <tmaimon77@...il.com>,
        "gcwilson@...ibm.com" <gcwilson@...ibm.com>,
        "kgoldman@...ibm.com" <kgoldman@...ibm.com>,
        "Dan.Morav@...oton.com" <Dan.Morav@...oton.com>,
        "oren.tanami@...oton.com" <oren.tanami@...oton.com>,
        "shmulik.hager@...oton.com" <shmulik.hager@...oton.com>,
        "amir.mizinski@...oton.com" <amir.mizinski@...oton.com>,
        Christophe Richard <hristophe-h.ricard@...com>
Subject: RE: [PATCH v4 2/7] tpm: tpm_tis: Add check_data handle to
 tpm_tis_phy_ops in order to check data integrity

>>On Tue, Mar 31, 2020 at 02:32:02PM +0300, amirmizi6@...il.com wrote:
>> From: Amir Mizinski <amirmizi6@...il.com>
>> 
>> In order to compute the crc over the data sent in lower layer  (I2C 
>> for instance), tpm_tis_check_data() calls an operation (if available)  
>> to check data integrity. If data integrity cannot be verified, a retry  
>> attempt to save the sent/received data is implemented.
>> 
>> The current steps are done when sending a command:
>>     1. Host writes to TPM_STS.commandReady.
>>     2. Host writes command.
>>     3. Host checks that TPM received data is valid.
>>     4. If data is currupted go to step 1.
>> 
>> When receiving data:
>>     1. Host checks that TPM_STS.dataAvail is set.
>>     2. Host saves received data.
>>     3. Host checks that received data is correct.
>>     4. If data is currupted Host writes to TPM_STS.responseRetry and go to
>>         step 1.
>> 
>> Co-developed-by: Christophe Richard <hristophe-h.ricard@...com>
>> Signed-off-by: Christophe Richard <hristophe-h.ricard@...com>
>> Signed-off-by: Amir Mizinski <amirmizi6@...il.com>

>The email is malformed.

>So.. How did Christophe participate on writing this patch? I haven't seen him shouting anything about the subject and still his SOB is there.

>/Jarkko

Christophe sent patch to support I2C TCG TPM driver tpm_tis_i2c (https://patchwork.kernel.org/patch/8628681/) in the same time that tpm_tis_spi. This function was named tpm_tis_i2c_check_data.

Best Regards,