linux-kernel - Re: [GIT PULL] HID for 5.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgy8AM+BOt4jhnoQ+wa=YVyXT4ARg=qEYC=S-OW4ZjZzw@mail.gmail.com>
Date:   Wed, 1 Apr 2020 15:57:44 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] HID for 5.7

On Wed, Apr 1, 2020 at 5:11 AM Jiri Kosina <jikos@...nel.org> wrote:
>
> Samuel Čavoj (1):
>       HID: Add driver fixing Glorious PC Gaming Race mouse report descriptor

What a glorious name for a piece of hardware. Even if it's apparently
buggy and needs help to work right.

I felt bad saying I don't need that glorious driver when doing my oldconfig.

Anyway, because I noticed this due to the name, it does strike me that
clearly Windows must be ignoring - or otherwise reacting differently
to - the HID_MAIN_ITEM_CONSTANT flag. Because presumably those mice
work under Windows without special drivers?

In fact, reading that driver, it looks like they report being *both*
constant *and* variable in their report descriptors. Which sounds odd.
Maybe we should do whatever Windows does, and not need a special
driver for this maybe-bot-so-glorious-after-all mouse hardware?

Hmm?

              Linus