linux-kernel - Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12cdbe77-b932-9194-5d5e-5058622cef6c@microchip.com>
Date:   Wed, 1 Apr 2020 07:50:58 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <andrew@...n.ch>
CC:     <f.fainelli@...il.com>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>
Subject: Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY

On 31.03.2020 15:59, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> Thanks guys. I thought there might be other controllers that have the
>> PHY nodes inside the ethernet node.
> 
> Hi Codrin

Hi Andrew

> 
> There are some still using this deprecated feature. But macb is the
> only one doing this odd looping over child nodes. It is this looping
> which is breaking things, not the use of the deprecated feature
> itself.

Yes, its due to the fact that the MDIO node is missing. Should we have 
in mind to add an MDIO node under the macb node, where we could add the 
PHY nodes? The macb bindings don't seem to require the PHY nodes 
directly under the macb node, but the compatibility with the deprecated 
feature needs to be maintained.

Best regards,
Codrin