[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a11d5c9-b830-040e-219a-64cdb24a9236@suse.cz>
Date: Wed, 1 Apr 2020 10:47:07 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc: Luis Chamberlain <mcgrof@...nel.org>,
Kees Cook <keescook@...omium.org>,
Iurii Zaikin <yzaikin@...gle.com>,
linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
linux-mm@...ck.org, Ivan Teterevkov <ivan.teterevkov@...anix.com>,
Michal Hocko <mhocko@...nel.org>,
David Rientjes <rientjes@...gle.com>,
Matthew Wilcox <willy@...radead.org>,
"Eric W . Biederman" <ebiederm@...ssion.com>,
"Guilherme G . Piccoli" <gpiccoli@...onical.com>,
Alexey Dobriyan <adobriyan@...il.com>,
Thomas Gleixner <tglx@...utronix.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Christian Brauner <christian.brauner@...ntu.com>
Subject: Re: [PATCH 3/3] kernel/hung_task convert hung_task_panic boot
parameter to sysctl
On 4/1/20 1:12 AM, Tetsuo Handa wrote:
> On 2020/03/30 20:55, Vlastimil Babka wrote:
>> @@ -63,16 +63,6 @@ static struct task_struct *watchdog_task;
>> unsigned int __read_mostly sysctl_hung_task_panic =
>> CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE;
>>
>> -static int __init hung_task_panic_setup(char *str)
>> -{
>> - int rc = kstrtouint(str, 0, &sysctl_hung_task_panic);
>> -
>> - if (rc)
>> - return rc;
>> - return 1;
>> -}
>> -__setup("hung_task_panic=", hung_task_panic_setup);
>
> Can we defer removal of this handler for "one release cycle" (and instead emit a line
> saying that "this parameter will be replaced by ..." during that cycle) ? I welcome
The old parameter is not removed, it's just handled differently, see patch 2.
Both old name and new sysctl.name will work.
> PATCH 1/3, but kernel testing projects (e.g. syzbot) needs to update their settings
> between PATCH 1/3 was merged into linux.git and PATCH 3/3 is merged into linux.git .
>
> https://lkml.kernel.org/r/CACT4Y+YE-j5ncjTGN6UhngfCNRgVo-QDZ3VCBGACdbs9-v+axQ@mail.gmail.com says
> "Announcing unmerged changes is too early (as this patch showed). And once it's in linux-next it's already too late.."
>
>> -
>> static int
>> hung_task_panic(struct notifier_block *this, unsigned long event, void *ptr)
>> {
>>
>
Powered by blists - more mailing lists