lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Apr 2020 13:26:58 +0100 From: Lukasz Luba <lukasz.luba@....com> To: Amit Kucheria <amit.kucheria@...aro.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, swboyd@...omium.org, mka@...omium.org, daniel.lezcano@...aro.org, Amit Kucheria <amit.kucheria@...durent.com>, Zhang Rui <rui.zhang@...el.com> Cc: Rob Herring <robh@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH v4 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones Hi Amit, Apart from small mistake during probably copy-paste (please check below), looks good. On 4/1/20 12:15 PM, Amit Kucheria wrote: > As part of moving the thermal bindings to YAML, split it up into 3 > bindings: thermal sensors, cooling devices and thermal zones. > > The thermal-zone binding is a software abstraction to capture the > properties of each zone - how often they should be checked, the > temperature thresholds (trips) at which mitigation actions need to be > taken and the level of mitigation needed at those thresholds. > > Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org> > Reviewed-by: Rob Herring <robh@...nel.org> > --- > Changes since v3: > - Clarify example by using cooling state numbers and a comment > - Restrict thermal-sensors to a single reference to reflect actual code > where there is a one-to-one mapping between sensors and thermal zones > - Add two optional properties that were missed in earlier submissions: > coefficients and sustainable-power > - Improve description of hysteresis and contribution properties > > .../bindings/thermal/thermal-zones.yaml | 341 ++++++++++++++++++ > 1 file changed, 341 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/thermal-zones.yaml > [snip] > + cooling-maps { > + map0 { > + trip = <&cpu0_alert0>; > + /* Corresponds to 1400MHz in OPP table */ > + cooling-device = <&CPU0 3 3>, <&CPU1 3 3>, > + <&CPU2 3 3>, <&CPU3 3 3>; > + }; > + > + map1 { > + trip = <&cpu0_alert1>; > + /* Corresponds to 1400MHz in OPP table */ s/1400MHz/1000MHz/ 1400MHZ is used in map0 as <&CPUx 3 3>, here we have '5 5'. > + cooling-device = <&CPU0 5 5>, <&CPU1 5 5>, > + <&CPU2 5 5>, <&CPU3 5 5>; > + }; > + }; > + }; Apart from that, looks good: Reviewed-by: Lukasz Luba <lukasz.luba@....com> Regards, Lukasz
Powered by blists - more mailing lists