linux-kernel - Re: linux-next: build failure after merge of the gpio tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfnsXZ9YqnU1=9MYwRTQ+gDU_jh4VcNKCQvZDsCgN7AYg@mail.gmail.com>
Date:   Wed, 1 Apr 2020 15:30:34 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>
Subject: Re: linux-next: build failure after merge of the gpio tree

On Wed, Apr 1, 2020 at 3:29 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Wed, Apr 1, 2020 at 11:26 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > On Wed, Apr 1, 2020 at 10:19 AM Linus Walleij <linus.walleij@...aro.org> wrote:
> > > On Wed, Apr 1, 2020 at 9:49 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > > > > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
> > > >
> > > > As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> > > > function, what about making it an inline function in
> > > > include/linux/pinctrl/pinctrl.h instead?
> > >
> > > I'm all for it! :)
> >
> > Want me to send a patch?
> > Which base?
>
> Wouldn't we need to export the inside function in that case?
> If so, we need a better name for it.

And wouldn't be cost even more expensive in such case due length of
the function name?


-- 
With Best Regards,
Andy Shevchenko