linux-kernel - Re: [PATCH v5 2/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+HBbNEcrHgB1_ydaOaPKEWB6L6vrWNf=DYxt5YwdCoqYpLEqw@mail.gmail.com>
Date:   Wed, 1 Apr 2020 18:27:02 +0200
From:   Robert Marko <robert.marko@...tura.hr>
To:     Rob Herring <robh@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, John Crispin <john@...ozen.org>,
        Luka Perkov <luka.perkov@...tura.hr>
Subject: Re: [PATCH v5 2/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document

On Wed, Apr 1, 2020 at 5:45 PM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, Mar 31, 2020 at 10:39 AM Robert Marko <robert.marko@...tura.hr> wrote:
> >
> > On Tue, Mar 31, 2020 at 6:31 PM Rob Herring <robh@...nel.org> wrote:
> > >
> > > On Mon, 30 Mar 2020 18:43:29 +0200, Robert Marko wrote:
> > > > This patch adds the binding documentation for the HS/SS USB PHY found
> > > > inside Qualcom Dakota SoCs.
> > > >
> > > > Signed-off-by: John Crispin <john@...ozen.org>
> > > > Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> > > > Cc: Luka Perkov <luka.perkov@...tura.hr>
> > > > ---
> > > > Changes from v4 to v5:
> > > > * Replace tabs with whitespaces
> > > > * Add maintainer property
> > > >
> > > >  .../bindings/phy/qcom-usb-ipq4019-phy.yaml    | 48 +++++++++++++++++++
> > > >  1 file changed, 48 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
> > > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > Error: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts:21.25-26 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml' failed
> > > make[1]: *** [Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > Makefile:1262: recipe for target 'dt_binding_check' failed
> > > make: *** [dt_binding_check] Error 2
> > >
> > > See https://patchwork.ozlabs.org/patch/1264091
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure dt-schema is up to date:
> > >
> > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> > >
> > > Please check and re-submit.
> > Hi Rob,
> > I tested locally before submitting and it will pass.
>
> Impossible. Your example has defines, but there are no include files listed.
I don't know how it passed, but I definitively tested with make
dtbs_check and then make dt_binding_check
It could possibly be old DT schema files, I updated today and now it pops up.
I will fix it and send a new version ASAP.

Thanks
>
> Rob