linux-kernel - Re: [PATCH] Revert "gpio: eic-sprd: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYYsPKFBKPVXHa-k5jmQ_8BPfpqmWAUNfSNzar+CedXmA@mail.gmail.com>
Date:   Thu, 2 Apr 2020 09:40:05 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Baolin Wang <baolin.wang7@...il.com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Lyra Zhang <zhang.lyra@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "gpio: eic-sprd: Use devm_platform_ioremap_resource()"

On Wed, Apr 1, 2020 at 11:59 AM Baolin Wang <baolin.wang7@...il.com> wrote:

> This reverts commit 0f5cb8cc27a266c81e6523b436479802e9aafc9e.
>
> This commit will cause below warnings, since our EIC controller can support
> differnt banks on different Spreadtrum SoCs, and each bank has its own base
> address, we will get invalid resource warning if the bank number is less than
> SPRD_EIC_MAX_BANK on some Spreadtrum SoCs.
>
> So we should not use devm_platform_ioremap_resource() here to remove the
> warnings.
>
> [    1.118508] sprd-eic 40210000.gpio: invalid resource
> [    1.118535] sprd-eic 40210000.gpio: invalid resource
> [    1.119034] sprd-eic 40210080.gpio: invalid resource
> [    1.119055] sprd-eic 40210080.gpio: invalid resource
> [    1.119462] sprd-eic 402100a0.gpio: invalid resource
> [    1.119482] sprd-eic 402100a0.gpio: invalid resource
> [    1.119893] sprd-eic 402100c0.gpio: invalid resource
> [    1.119913] sprd-eic 402100c0.gpio: invalid resource
>
> Signed-off-by: Baolin Wang <baolin.wang7@...il.com>

Patch applied.

Yours,
Linus Walleij