linux-kernel - Re: [PATCH] staging: rtl8712: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200402081211.GC2001@kadam>
Date:   Thu, 2 Apr 2020 01:12:12 -0700 (PDT)
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aiman Najjar <aiman.najjar@...ranet.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: fix checkpatch warnings

On Thu, Mar 26, 2020 at 01:56:16AM -0400, Aiman Najjar wrote:
> @@ -350,7 +351,7 @@ static int xmitframe_addmic(struct _adapter *padapter,
>  	struct	sta_info *stainfo;
>  	struct	qos_priv *pqospriv = &(padapter->mlmepriv.qospriv);
>  	struct	pkt_attrib  *pattrib = &pxmitframe->attrib;
> -	struct	security_priv *psecuritypriv = &padapter->securitypriv;
> +	struct	security_priv *psecpriv = &padapter->securitypriv;

This patch is doing too many things of course, but the other problem is
that when you're renaming variables we don't what them to start with "p"
to mean that they are a pointer.  "psecpriv" should just be "secpriv".
That name is still kind of rubbish, but it's not against the rules like
starting with a p for pointer.

regards,
dan carpenter