linux-kernel - Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6170e88e-5242-30dd-f624-1171aaa994de@huawei.com>
Date:   Thu, 2 Apr 2020 16:37:41 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jason Yan <yanaijie@...wei.com>, <jaegeuk@...nel.org>,
        <chao@...nel.org>, <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable
 'params'

Hi Jason,

On 2020/4/2 14:15, Jason Yan wrote:
> Fix the following gcc warning:
> 
> fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
>   ZSTD_parameters params;
>                   ^~~~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Thanks for the patch, would you mind that just merge this fix into
original path which is still in f2fs private git tree?

Thanks,

> ---
>  fs/f2fs/compress.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index f05ecf4cb899..df7b2d15eacd 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
>  
>  static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
>  {
> -	ZSTD_parameters params;
>  	ZSTD_DStream *stream;
>  	void *workspace;
>  	unsigned int workspace_size;
>  
> -	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
>  	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
>  
>  	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
>