linux-kernel - Re: [PATCH] bcache: remove redundant variables i and n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de88ae08-1200-285b-cd1b-cfd723d2da56@suse.de>
Date:   Thu, 2 Apr 2020 19:34:09 +0800
From:   Coly Li <colyli@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: remove redundant variables i and n

On 2020/4/2 7:19 下午, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variables i and n are being assigned but are never used. They are
> redundant and can be removed.
> 

Hi Colin,

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, I will submit this patch in Linux 5.7-rc series.

> ---
>  drivers/md/bcache/btree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 72856e5f23a3..114d0d73d909 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1907,10 +1907,8 @@ static int bch_btree_check_thread(void *arg)
>  	struct btree_iter iter;
>  	struct bkey *k, *p;
>  	int cur_idx, prev_idx, skip_nr;
> -	int i, n;
>  
>  	k = p = NULL;
> -	i = n = 0;
>  	cur_idx = prev_idx = 0;
>  	ret = 0;
>  
> 


-- 

Coly Li