linux-kernel - Re: [PATCH] efi/libstub/x86: remove redundant assignment to pointer hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXF=v5QNEPdzFuwuE6-FTysGV1qTfsHLRFkbgG8sjMcAMQ@mail.gmail.com>
Date:   Thu, 2 Apr 2020 14:31:36 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        linux-efi <linux-efi@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi/libstub/x86: remove redundant assignment to pointer hdr

On Thu, 2 Apr 2020 at 12:25, Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The pointer hdr is being assigned a value that is never read and
> it is being updated later with a new value. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks Colin. I'll queue this up.

> ---
>  drivers/firmware/efi/libstub/x86-stub.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
> index 8d3a707789de..e02ea51273ff 100644
> --- a/drivers/firmware/efi/libstub/x86-stub.c
> +++ b/drivers/firmware/efi/libstub/x86-stub.c
> @@ -392,8 +392,6 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
>         image_base = efi_table_attr(image, image_base);
>         image_offset = (void *)startup_32 - image_base;
>
> -       hdr = &((struct boot_params *)image_base)->hdr;
> -
>         status = efi_allocate_pages(0x4000, (unsigned long *)&boot_params, ULONG_MAX);
>         if (status != EFI_SUCCESS) {
>                 efi_printk("Failed to allocate lowmem for boot params\n");
> --
> 2.25.1
>