[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200402115851.GG3683@piout.net>
Date: Thu, 2 Apr 2020 13:58:51 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Tang Bin <tangbin@...s.chinamobile.com>
Cc: perex@...ex.cz, tiwai@...e.com, nicolas.ferre@...rochip.com,
ludovic.desroches@...rochip.com, alsa-devel@...a-project.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional()
On 02/04/2020 19:21:35+0800, Tang Bin wrote:
> In order to simply code,because platform_get_irq() already has
> dev_err() message.
>
But what I see is a dev_dbg message so your patch actually changes the
behaviour when debugging is not enabled.
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
> sound/atmel/ac97c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a1dce9725..25cfd5710 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq < 0) {
> dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
> return irq;
> --
> 2.20.1.windows.1
>
>
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists