[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8470370b-5359-4b82-ed55-8018f8b60697@huawei.com>
Date: Thu, 2 Apr 2020 10:09:17 +0100
From: John Garry <john.garry@...wei.com>
To: YueHaibing <yuehaibing@...wei.com>, <jejb@...ux.ibm.com>,
<martin.petersen@...cle.com>, <chenxiang66@...ilicon.com>,
<b.zolnierkie@...sung.com>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: hisi_sas: Fix build error without SATA_HOST
On 02/04/2020 09:58, YueHaibing wrote:
> If SATA_HOST is n, build fails:
>
> drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd':
> hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis'
>
> Select SATA_HOST to fix this.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: bd322af15ce9 ("ata: make SATA_PMP option selectable only if any SATA host driver is enabled")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Acked-by: John Garry <john.garry@...wei.com>
> ---
> v2: use correct Fixes tag
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 90a17452a50d..13ed9073fc72 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -6,6 +6,7 @@ config SCSI_HISI_SAS
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> depends on ATA
> + select SATA_HOST
> help
> This driver supports HiSilicon's SAS HBA, including support based
> on platform device
>
Powered by blists - more mailing lists