linux-kernel - Re: [PATCH] tty/sysrq: Export sysrq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pncqu0cv.fsf@mpe.ellerman.id.au>
Date:   Thu, 02 Apr 2020 12:45:20 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dmitry Safonov <dima@...sta.com>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Safonov <0x7f454c46@...il.com>,
        "kernelci.org bot" <bot@...nelci.org>, Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH] tty/sysrq: Export sysrq_mask()

Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:
> On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
>> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
>> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
>> >> Build fix for serial_core being module:
>> >>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>> >>
>> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> >> Cc: Jiri Slaby <jslaby@...e.com>
>> >> Reported-by: "kernelci.org bot" <bot@...nelci.org>
>> >> Reported-by: Michael Ellerman <mpe@...erman.id.au>
>> >> Signed-off-by: Dmitry Safonov <dima@...sta.com>
>> >> ---
>> >>  drivers/tty/sysrq.c | 1 +
>> >>  1 file changed, 1 insertion(+)
>> > 
>> > Is this a new problem?  What commit does this fix?
>> 
>> Right, sorry I've managed to forget adding the tag:
>> 
>> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
>> 
>> Maybe also:
>> 
>> Link:
>> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
>
> Thanks, that works.  WIll queue this up after -rc1 is out.

Why wait until after rc1?

It's a build break for a bunch of folks and the fix is obviously correct
(famous last words).

cheers