linux-kernel - Re: [PATCH] ACPI: PPTT: Inform user that table offset used for Physical processor node ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f68a3c-264a-5d1b-e63a-d1147ea07320@arm.com>
Date:   Thu, 2 Apr 2020 08:55:31 -0500
From:   Jeremy Linton <jeremy.linton@....com>
To:     John Garry <john.garry@...wei.com>, rjw@...ysocki.net,
        lenb@...nel.org
Cc:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        sudeep.holla@....com, linuxarm@...wei.com, wanghuiqiang@...wei.com
Subject: Re: [PATCH] ACPI: PPTT: Inform user that table offset used for
 Physical processor node ID

Hi,

On 4/2/20 7:22 AM, John Garry wrote:
> If the the Processor ID valid is not set for a Physical Processor Package
> node, then the node table offset is used as a substitute. As such, we
> may get info like this from sysfs:
> 
> root@(none)$ pwd
> /sys/devices/system/cpu/cpu0/topology
> root@(none)$ more physical_package_id
> 56
> 
> Inform the user of this in the bootlog, as it is much less than ideal, and
> they can remedy this in their FW.
> 
> This topic was originally discussed in:
> https://lore.kernel.org/linux-acpi/c325cfe2-7dbf-e341-7f0f-081b6545e890@huawei.com/T/#m0ec18637d8586f832084a8a6af22580e6174669a
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> 
> diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
> index 4ae93350b70d..b4ed3c818e00 100644
> --- a/drivers/acpi/pptt.c
> +++ b/drivers/acpi/pptt.c
> @@ -515,6 +515,8 @@ static int topology_get_acpi_cpu_tag(struct acpi_table_header *table,
>   		if (level == 0 ||
>   		    cpu_node->flags & ACPI_PPTT_ACPI_PROCESSOR_ID_VALID)
>   			return cpu_node->acpi_processor_id;
> +		if (level == PPTT_ABORT_PACKAGE)
> +			pr_notice_once("Physical package node Processor ID valid not set, will use table offset as substitute\n");

What happens in the find_acpi_cpu_topology_hetro_id() case, if the last 
IDENTICAL node isn't a socket/etc. Are we expecting to warn of a missing 
processor container there as well?



>   		return ACPI_PTR_DIFF(cpu_node, table);
>   	}
>   	pr_warn_once("PPTT table found, but unable to locate core %d (%d)\n",
>