[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200402155810.GD9352@zn.tnic>
Date: Thu, 2 Apr 2020 17:58:10 +0200
From: Borislav Petkov <bp@...en8.de>
To: Nick Terrell <terrelln@...com>
Cc: Nick Terrell <nickrterrell@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Chris Mason <clm@...com>,
"linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
"x86@...nel.org" <x86@...nel.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
Petr Malat <oss@...at.biz>, Kees Cook <keescook@...omium.org>,
Kernel Team <Kernel-team@...com>,
Adam Borowski <kilobyte@...band.pl>,
Patrick Williams <patrickw3@...com>,
Michael van der Westhuizen <rmikey@...com>,
"mingo@...nel.org" <mingo@...nel.org>,
Patrick Williams <patrick@...cx.xyz>,
Sedat Dilek <sedat.dilek@...il.com>
Subject: Re: [PATCH v4 6/8] x86: bump ZO_z_extra_bytes margin for zstd
On Wed, Apr 01, 2020 at 05:33:03PM +0000, Nick Terrell wrote:
> The code is currently written so that all the compression algorithms use the
> same ZO_z_extra_bytes. It is taken to be the maximum of the growth rate
> plus the maximum fixed overhead. Just a few lines above is the comment:
>
> # … Hence safety
> # margin should be updated to cover all decompressors so that we don't
> # need to deal with each of them separately. Please check
> # the description in lib/decompressor_xxx.c for specific information.
>
> So I was been following the guidance in the comments.
Please state that in the commit message when you send your next
revision.
> Does it matter? I’m not an expert here,
Huh, you're only sending the code then? Or what do you mean with not
being an expert?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists