linux-kernel - Re: [PATCH] mailbox: armada-37xx-rwtm: Remove duplicate error messages in armada_37xx_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2f136a63-72d5-43ef-2a73-67d6984b848d@web.de>
Date:   Fri, 3 Apr 2020 21:45:21 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tang Bin <tangbin@...s.chinamobile.com>,
        Jassi Brar <jassisinghbrar@...il.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mailbox: armada-37xx-rwtm: Remove duplicate error
 messages in armada_37xx_mbox_probe()

> In this function,we don't need dev_err() message because when something
> goes wrong,platform_get_irq() and devm_platform_ioremap_resource() have
> print an error message itself, so we should remove duplicate dev_err().

I suggest further fine-tuning also for this commit message.

Regards,
Markus