lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Apr 2020 15:41:56 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Colin King <colin.king@...onical.com> Cc: Boris Brezillon <bbrezillon@...nel.org>, Arnaud Ebalard <arno@...isbad.org>, Srujana Challa <schalla@...vell.com>, "David S . Miller" <davem@...emloft.net>, Lukasz Bartosik <lbartosik@...vell.com>, linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][next] crypto: marvell: fix double free of ptr On Thu, Apr 02, 2020 at 12:10:12AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Currently in the case where eq->src != req->ds, the allocation of > ptr is kfree'd at the end of the code block. However later on in > the case where enc is not null any of the error return paths that > return via the error handling return path end up performing an > erroneous second kfree of ptr. > > Fix this by adding an error exit label error_free and only jump to > this when ptr needs kfree'ing thus avoiding the double free issue. > > Addresses-Coverity: ("Double free") > Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/crypto/marvell/octeontx/otx_cptvf_algs.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists