linux-kernel - Re: [PATCH] net: dsa: mt7530: fix null pointer dereferencing in port5 setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200403.161139.2115986079787627095.davem@davemloft.net>
Date:   Fri, 03 Apr 2020 16:11:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gch981213@...il.com
Cc:     netdev@...r.kernel.org, stable@...r.kernel.org,
        sean.wang@...iatek.com, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, matthias.bgg@...il.com,
        opensource@...rst.com, rmk+kernel@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mt7530: fix null pointer dereferencing in
 port5 setup

From: Chuanhong Guo <gch981213@...il.com>
Date: Fri,  3 Apr 2020 19:28:24 +0800

> The 2nd gmac of mediatek soc ethernet may not be connected to a PHY
> and a phy-handle isn't always available.
> Unfortunately, mt7530 dsa driver assumes that the 2nd gmac is always
> connected to switch port 5 and setup mt7530 according to phy address
> of 2nd gmac node, causing null pointer dereferencing when phy-handle
> isn't defined in dts.
> This commit fix this setup code by checking return value of
> of_parse_phandle before using it.
> 
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Chuanhong Guo <gch981213@...il.com>
> Cc: stable@...r.kernel.org

Please do not CC: stable for networking changes, as per:

	Documentation/networking/netdev-FAQ.rstq

Applied and queued up for -stable, thank you.