linux-kernel - Re: [PATCH] powerpc/mm: ptdump: Add missing include <asm/vio.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e7bc589-3727-eebb-8727-407944114494@huawei.com>
Date:   Fri, 3 Apr 2020 14:26:41 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Michael Ellerman <mpe@...erman.id.au>, <benh@...nel.crashing.org>,
        <paulus@...ba.org>, <gregkh@...uxfoundation.org>,
        <christophe.leroy@....fr>, <allison@...utok.net>,
        <armijn@...ldur.nl>, <tglx@...utronix.de>,
        <aneesh.kumar@...ux.ibm.com>
CC:     <linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/mm: ptdump: Add missing include <asm/vio.h>

On 2020/4/3 12:58, Michael Ellerman wrote:
> YueHaibing <yuehaibing@...wei.com> writes:
>> gcc build fails:
> 
> What config? Custom?

A randconfig, CONFIG_PPC_PSERIES  is not set,  see attach.

> 
>> arch/powerpc/mm/ptdump/hashpagetable.c: In function ‘pseries_find’:
>> arch/powerpc/mm/ptdump/hashpagetable.c:262:18: error: ‘H_SUCCESS’ undeclared (first use in this function); did you mean ‘FL_ACCESS’?
>>    if (lpar_rc != H_SUCCESS)
>>                   ^~~~~~~~~
>>                   FL_ACCESS
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Fixes: 65e701b2d2a8 ("powerpc/ptdump: drop non vital #ifdefs")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  arch/powerpc/mm/ptdump/hashpagetable.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/mm/ptdump/hashpagetable.c b/arch/powerpc/mm/ptdump/hashpagetable.c
>> index b6ed9578382f..8ea5f9a3b658 100644
>> --- a/arch/powerpc/mm/ptdump/hashpagetable.c
>> +++ b/arch/powerpc/mm/ptdump/hashpagetable.c
>> @@ -20,6 +20,7 @@
>>  #include <asm/page.h>
>>  #include <asm/pgalloc.h>
>>  #include <asm/plpar_wrappers.h>
>> +#include <asm/vio.h>
> 
> I don't think you want vio.h, hvcall.h has the definition of H_SUCCESS.

Ok, will resend.

> 
> cheers
> 
> .
> 

View attachment "randconfig" of type "text/plain" (88098 bytes)