linux-kernel - Re: [PATCH v4 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200403070114.GD25305@linux.intel.com>
Date:   Fri, 3 Apr 2020 10:01:26 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-security-module@...r.kernel.org,
        Stefan Berger <stefanb@...ux.ibm.com>
Subject: Re: [PATCH v4 0/2] tpm2: Make TPM2 logs accessible for non-UEFI
 firmware

On Thu, Apr 02, 2020 at 06:51:38PM -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb@...ux.ibm.com>
> 
> This series of patches extends the existing TPM2 ACPI table with additional
> fields found in the TPM2 TCG ACPI specification (reference is in the patch)
> that allow access to the log's address and its size. We then modify the
> code that so far only enables access to a TPM 1.2's log for a TPM2 as well.
> This then enables access to the TPM2's log on non-UEFI system that for example
> run SeaBIOS.
> 
>    Stefan
> 
> v3->v4:
>   - Repost as one series
> 
> v2->v3:
>   - Split the series into two separate patches
>   - Added comments to ACPI table fields
>   - Added check for null pointer to log area and zero log size
> 
> v1->v2:
>   - Repost of the series
> 
> 
> 
> Stefan Berger (2):
>   acpi: Extend TPM2 ACPI table with missing log fields
>   tpm: Add support for event log pointer found in TPM2 ACPI table
> 
>  drivers/char/tpm/eventlog/acpi.c | 56 +++++++++++++++++++++++++---------------
>  drivers/char/tpm/tpm_crb.c       | 13 +++++++---
>  drivers/char/tpm/tpm_tis.c       |  4 ++-
>  include/acpi/actbl3.h            |  5 ++--
>  4 files changed, 51 insertions(+), 27 deletions(-)
> 
> -- 
> 2.14.5
> 

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

I'll apply this after I'll get Rafael's answer whether I can add his ack
to the commits.

/Jarkko