linux-kernel - [PATCH v2]ARM:zx:Delete duplicate dev_err message in zx296702_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20200403082423.8800-1-tangbin@cmss.chinamobile.com>
Date:   Fri,  3 Apr 2020 16:24:23 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     jun.nie@...aro.org, shawnguo@...nel.org, linux@...linux.org.uk
Cc:     narmstrong@...libre.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Tang Bin <tangbin@...s.chinamobile.com>
Subject: [PATCH v2]ARM:zx:Delete duplicate dev_err message in zx296702_pd_probe()

In this place,devm_ioremap_resource() has already contains error
message, so delete the duplicate dev_err message.

Changes from v1:
 - the title has changed, because the description is not very detailed
   and the formate is wrong. So I find an other wording more appropriate.

As suggested by Markus Elfring:
   This is another attempt for the previous update suggestion, v1 can be
   found here: https://lore.kernel.org/patchwork/patch/1203764/

Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
---
 arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
index 7a08bf9dd..ac44ea8e6 100644
--- a/arch/arm/mach-zx/zx296702-pm-domain.c
+++ b/arch/arm/mach-zx/zx296702-pm-domain.c
@@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
 	}
 
 	pcubase = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(pcubase)) {
-		dev_err(&pdev->dev, "ioremap fail.\n");
+	if (IS_ERR(pcubase))
 		return -EIO;
-	}
 
 	for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
 		pm_genpd_init(zx296702_pm_domains[i], NULL, false);
-- 
2.20.1.windows.1