linux-kernel - Re: [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200403083043.GW2001@kadam>
Date:   Fri, 3 Apr 2020 11:30:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "John B. Wyatt IV" <jbwyatt4@...il.com>
Cc:     outreachy-kernel@...glegroups.com,
        Ioana Radulescu <ruxandra.radulescu@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment

On Wed, Apr 01, 2020 at 07:33:10PM -0700, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
> 
> Reported by checkpatch.
> 
> Signed-off-by: John B. Wyatt IV <jbwyatt4@...il.com>
> ---
>  drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> index 676d1ad1b50d..546ad376df99 100644
> --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> @@ -1094,7 +1094,8 @@ static int swdev_port_obj_del(struct net_device *netdev,
>  
>  static int
>  ethsw_switchdev_port_attr_set_event(struct net_device *netdev,
> -		struct switchdev_notifier_port_attr_info *port_attr_info)
> +				    struct switchdev_notifier_port_attr_info
> +				    *port_attr_info)

I feel like the end result is worse than the original code because of
how the type and the parameter name are on different lines.  Sorry.  :/

regards,
dan carpenter