linux-kernel - Re: [PATCH][V2][next] rtc: ds1307: check for failed memory allocation on wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200403084504.GZ2001@kadam>
Date:   Fri, 3 Apr 2020 11:45:04 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Colin King <colin.king@...onical.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        linux-rtc@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2][next] rtc: ds1307: check for failed memory
 allocation on wdt

On Thu, Apr 02, 2020 at 04:53:12PM +0200, Alexandre Belloni wrote:
> 
> As stated, I also prefer keeping the watchdog optional and ignore the
> error.

Hopefully you aren't running out of memory on start up.  In current
kernels small memory allocations like this never fail so it doesn't
really affect runtime.  It only silences the NULL dereference static
checker warning.

regards,
dan carpenter