linux-kernel - Re: [PATCH] crypto: amlogic - Delete duplicate dev_err in meson_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e1916128-6554-ea57-49ef-e4ad7b0d7229@web.de>
Date:   Fri, 3 Apr 2020 10:45:21 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tang Bin <tangbin@...s.chinamobile.com>,
        linux-amlogic@...ts.infradead.org, linux-crypto@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Corentin Labbe <clabbe@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH] crypto: amlogic - Delete duplicate dev_err in
 meson_crypto_probe()

> In this place,

I suggest to omit such a wording from the change description.


> when something goes wrong, platform_get_irq() will
> print an error message,

This information is helpful here.


> so in order to avoid the situation of repeat output，

Possible adjustments:
* Separate sentences

* “repeated output”


> we should remove dev_err here.

Thus remove a redundant function call.


How do you think about to change any more source files in a systematic way?

Regards,
Markus