lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 3 Apr 2020 09:02:15 +0000
From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
CC:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Murray <andrew.murray@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Frank Rowand <frowand.list@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Simon Horman <horms@...ge.net.au>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Tom Joseph <tjoseph@...ence.com>,
        Heiko Stuebner <heiko@...ech.de>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        Lad Prabhakar <prabhakar.csengg@...il.com>
Subject: RE: [PATCH v6 07/11] dt-bindings: PCI: rcar: Add bindings for R-Car
 PCIe endpoint controller

Hi Shimoda-san,

Thank you for the review.

> -----Original Message-----
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> Sent: 03 April 2020 09:28
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>; Bjorn Helgaas <bhelgaas@...gle.com>; Rob Herring
> <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Geert Uytterhoeven <geert+renesas@...der.be>; Magnus Damm
> <magnus.damm@...il.com>; Kishon Vijay Abraham I <kishon@...com>; Lorenzo Pieralisi <lorenzo.pieralisi@....com>; Marek Vasut
> <marek.vasut+renesas@...il.com>; linux-pci@...r.kernel.org
> Cc: Catalin Marinas <catalin.marinas@....com>; Will Deacon <will@...nel.org>; Arnd Bergmann <arnd@...db.de>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Andrew Murray <andrew.murray@....com>; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-renesas-soc@...r.kernel.org; Chris Paterson <Chris.Paterson2@...esas.com>; Frank Rowand
> <frowand.list@...il.com>; Gustavo Pimentel <gustavo.pimentel@...opsys.com>; Jingoo Han <jingoohan1@...il.com>; Simon Horman
> <horms@...ge.net.au>; Shawn Lin <shawn.lin@...k-chips.com>; Tom Joseph <tjoseph@...ence.com>; Heiko Stuebner
> <heiko@...ech.de>; linux-rockchip@...ts.infradead.org; Lad Prabhakar <prabhakar.csengg@...il.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@...renesas.com>
> Subject: RE: [PATCH v6 07/11] dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller
>
> Hi Prabhakar-san,
>
> Thank you for your patch!
>
> > From: Lad Prabhakar, Sent: Friday, April 3, 2020 4:39 AM
> <snip>
> > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> > b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> > new file mode 100644
> > index 000000000000..07cd5a7325d0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> I'm sorry I should have mentioned in the previous review.
> This is better like the following.
>
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>
> https://patchwork.kernel.org/patch/11459267/#23246825
>
Argh my bad I should have noticed this too, usual tendency is to ignore the patch when its being Acked 😃

> <snip>
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/r8a774c0-cpg-mssr.h>
> > +    #include <dt-bindings/power/r8a774c0-sysc.h>
> > +
> > +     pcie0_ep: pcie-ep@...00000 {
> > +            compatible = "renesas,r8a774c0-pcie-ep",
> > +                         "renesas,rcar-gen3-pcie-ep";
> > +            reg = <0 0xfe000000 0 0x80000>,
> > +                  <0x0 0xfe100000 0 0x100000>,
> > +                  <0x0 0xfe200000 0 0x200000>,
> > +                  <0x0 0x30000000 0 0x8000000>,
> > +                  <0x0 0x38000000 0 0x8000000>;
>
> Examples are built with #{address,size}-cells = <1>, so
>
>             reg = <0xfe000000 0x80000>,
>                   <0xfe100000 0x100000>,
>                   <0xfe200000 0x200000>,
>                   <0x30000000 0x8000000>,
>                   <0x38000000 0x8000000>;
>
> https://patchwork.kernel.org/patch/11459267/#23246825
>
Will change this as above.

Cheers,
--Prabhakar

> Best regards,
> Yoshihiro Shimoda



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Powered by blists - more mailing lists