linux-kernel - RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 3 Apr 2020 09:31:43 +0000
From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Will Deacon <will@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Catalin Marinas <catalin.marinas@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Murray <andrew.murray@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Frank Rowand <frowand.list@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Simon Horman <horms@...ge.net.au>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Tom Joseph <tjoseph@...ence.com>,
        Heiko Stuebner <heiko@...ech.de>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        Lad Prabhakar <prabhakar.csengg@...il.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST

Hi Shimoda-san/Geert-san,

> -----Original Message-----
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> Sent: 03 April 2020 10:05
> To: Geert Uytterhoeven <geert@...ux-m68k.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
> Cc: Will Deacon <will@...nel.org>; Geert Uytterhoeven <geert+renesas@...der.be>; Catalin Marinas <catalin.marinas@....com>; Arnd
> Bergmann <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Andrew Murray <andrew.murray@....com>;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-renesas-soc@...r.kernel.org; Chris
> Paterson <Chris.Paterson2@...esas.com>; Frank Rowand <frowand.list@...il.com>; Gustavo Pimentel
> <gustavo.pimentel@...opsys.com>; Jingoo Han <jingoohan1@...il.com>; Simon Horman <horms@...ge.net.au>; Shawn Lin
> <shawn.lin@...k-chips.com>; Tom Joseph <tjoseph@...ence.com>; Heiko Stuebner <heiko@...ech.de>; linux-
> rockchip@...ts.infradead.org; Lad Prabhakar <prabhakar.csengg@...il.com>; Magnus Damm <magnus.damm@...il.com>; Kishon Vijay
> Abraham I <kishon@...com>; Lorenzo Pieralisi <lorenzo.pieralisi@....com>; Marek Vasut <marek.vasut+renesas@...il.com>; linux-
> pci@...r.kernel.org; Bjorn Helgaas <bhelgaas@...gle.com>; Rob Herring <robh+dt@...nel.org>; Mark Rutland
> <mark.rutland@....com>
> Subject: RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST
>
> Hi Geert-san,
>
> Thank you for your comments!
>
> > From: Geert Uytterhoeven, Sent: Friday, April 3, 2020 5:28 PM
> <snip>
> > > But, I'm thinking this patch (and patch 03/11) should be separated
> > > from this patch series for arm64 subsystem to ease maintenance.
> > > My scenario is:
> > >  1) patch series 1: R-Car PCIe endpoint support.
> > >  -- This means: patch 1, 4 - 9, 11
> > >
> > >  2) After the patch series 1 is merged, submit this patch 2/11 to arm subsystem
> > >    and submit the patch 10/11 to misc subsystem.
> > >
> > >  3) At last, submit patch 3/11 after the patch 2/11 is merged.
> > >
> > > Geert-san, what do you think?
> >
> > Thanks, I agree with your summary.
> >
> > I can take patch 2/11 through renesas-devel.
> > Probably it's best if I submit it to arm-soc as a fix for v5.8, after
> > the driver part
> > has been merged into v5.8-rc1, so 3/11 can be submitted for v5.9.
>
> Thank you! I got it.
>
Thank you, Ill split the patches accordingly and post a v7.

> > BTW, I'm wondering about "[PATCH v6 05/11] PCI: rcar: Fix calculating
> > mask for PCIEPAMR register". Can the issue fixed by this patch happen with
> > the current driver in host mode, or is that limited to ep mode?
> > In case of the former, please submit it to the PCI maintainer as a separate
> > fix.
>
> Thank you for pointed it out. I think this is the case of the former.
> IIUC, if such a small window PCIe device exists, the issue happens.
>
> Prabhakar-san, is my understanding correct?
>
This issue will only be hit on EP, when in host mode the sizes will be fixed to 1 Mbytes /2 Mbytes /128 Mbytes

Cheers,
--Prabhakar

> Best regards,
> Yoshihiro Shimoda



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647