linux-kernel - [PATCH] ns: Fix time_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Apr 2020 14:11:39 +0200
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Dmitry Safonov <dima@...sta.com>, Andrei Vagin <avagin@...nvz.or>
Cc:     mtk.manpages@...il.com, Adrian Reber <adrian@...as.de>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrei Vagin <avagin@...il.com>, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, Dmitry Safonov <0x7f454c46@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Andy Lutomirski <luto@...nel.org>,
        Cyrill Gorcunov <gorcunov@...il.com>,
        Containers <containers@...ts.linux-foundation.org>
Subject: [PATCH] ns: Fix time_for_children symlink

Dmitry, Andrei,

Looking at the contents of the /proc/PID/ns/time_for_children
symlink shows an anomaly:

$ ls -l /proc/self/ns/* |awk '{print $9, $10, $11}'
...
/proc/self/ns/pid -> pid:[4026531836]
/proc/self/ns/pid_for_children -> pid:[4026531836]
/proc/self/ns/time -> time:[4026531834]
/proc/self/ns/time_for_children -> time_for_children:[4026531834]
/proc/self/ns/user -> user:[4026531837]
...

The reference for 'time_for_children' should be a 'time' namespace,
just as the reference for 'pid_for_children' is a 'pid' namespace.
In other words, I think the above time_for_children link should read:

/proc/self/ns/time_for_children -> time:[4026531834]

If you agree with this patch, then it should be marked for
stable@...r.kernel.org.

Signed-off-by: Michael Kerrisk <mtk.manpages@...il.com>

---
 kernel/time/namespace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/time/namespace.c b/kernel/time/namespace.c
index e6ba064ce773..3b30288793fe 100644
--- a/kernel/time/namespace.c
+++ b/kernel/time/namespace.c
@@ -447,6 +447,7 @@ const struct proc_ns_operations timens_operations = {
 
 const struct proc_ns_operations timens_for_children_operations = {
 	.name		= "time_for_children",
+	.real_ns_name	= "time",
 	.type		= CLONE_NEWTIME,
 	.get		= timens_for_children_get,
 	.put		= timens_put,
-- 
2.25.1

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/