linux-kernel - Re: [PATCH] cedrus: Drop unneeded CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Apr 2020 09:21:49 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com, Hans Verkuil <hverkuil@...all.nl>,
        Maxime Ripard <mripard@...nel.org>
Subject: Re: [PATCH] cedrus: Drop unneeded CONFIG_OF dependency

On Fri, 2020-04-03 at 10:22 +0200, Paul Kocialkowski wrote:
> Hi Ezequiel,
> 
> On Thu 02 Apr 20, 16:46, Ezequiel Garcia wrote:
> > The driver is perfectly capable of being built without CONFIG_OF.
> > Remove this dependency, which is useful for compile-only tests.
> 
> Thanks for the patch!
> 
> Alas, the driver won't do anything useful without OF enabled, so it seems
> useful to keep that dependency.
> 

I'm not convinced about this argument, I like to have
dependencies on things the driver needs to compile
(except the machine option, see below).

> I would suggest making this a: depends on OF || COMPILE_TEST
> instead. What do you think?
> 

Although there are a handful, I don't see many drivers doing that.
To be honest, I don't like this much.

Also, if you want to make sure this driver can only be selected
where it makes sense, you consider having a ARCH_SUNXI || COMPILE_TEST.

IMO, the dependency on OF should be dropped as well.

Cheers,
Eze

> Cheers,
> 
> Paul
> 
> > Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> > ---
> >  drivers/staging/media/sunxi/cedrus/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/sunxi/cedrus/Kconfig b/drivers/staging/media/sunxi/cedrus/Kconfig
> > index 17733e9a088f..59b8d1b29865 100644
> > --- a/drivers/staging/media/sunxi/cedrus/Kconfig
> > +++ b/drivers/staging/media/sunxi/cedrus/Kconfig
> > @@ -3,7 +3,6 @@ config VIDEO_SUNXI_CEDRUS
> >  	tristate "Allwinner Cedrus VPU driver"
> >  	depends on VIDEO_DEV && VIDEO_V4L2 && MEDIA_CONTROLLER
> >  	depends on HAS_DMA
> > -	depends on OF
> >  	depends on MEDIA_CONTROLLER_REQUEST_API
> >  	select SUNXI_SRAM
> >  	select VIDEOBUF2_DMA_CONTIG
> > -- 
> > 2.26.0.rc2
> >