lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Apr 2020 15:14:42 +0200 From: <nicolas.ferre@...rochip.com> To: <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>, "Claudiu Beznea" <claudiu.beznea@...rochip.com>, <harini.katakam@...inx.com> CC: <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Alexandre Belloni <alexandre.belloni@...tlin.com>, <rafalo@...ence.com>, <sergio.prado@...abworks.com>, <antoine.tenart@...tlin.com>, <f.fainelli@...il.com>, <linux@...linux.org.uk>, <andrew@...n.ch>, <michal.simek@...inx.com>, Nicolas Ferre <nicolas.ferre@...rochip.com> Subject: [RFC PATCH 1/3] net: macb: fix wakeup test in runtime suspend/resume routines From: Nicolas Ferre <nicolas.ferre@...rochip.com> Use the proper struct device pointer to check if the wakeup flag and wakeup source are positioned. Use the one passed by function call which is equivalent to &bp->dev->dev.parent. It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan feature is used. Fixes: bc1109d04c39 ("net: macb: Add pm runtime support") Cc: Claudiu Beznea <claudiu.beznea@...rochip.com> Cc: Harini Katakam <harini.katakam@...inx.com> Cc: Rafal Ozieblo <rafalo@...ence.com> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com> --- drivers/net/ethernet/cadence/macb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index a0e8c5bbabc0..d1b4d6b6d7c8 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4616,7 +4616,7 @@ static int __maybe_unused macb_runtime_suspend(struct device *dev) struct net_device *netdev = dev_get_drvdata(dev); struct macb *bp = netdev_priv(netdev); - if (!(device_may_wakeup(&bp->dev->dev))) { + if (!(device_may_wakeup(dev))) { clk_disable_unprepare(bp->tx_clk); clk_disable_unprepare(bp->hclk); clk_disable_unprepare(bp->pclk); @@ -4632,7 +4632,7 @@ static int __maybe_unused macb_runtime_resume(struct device *dev) struct net_device *netdev = dev_get_drvdata(dev); struct macb *bp = netdev_priv(netdev); - if (!(device_may_wakeup(&bp->dev->dev))) { + if (!(device_may_wakeup(dev))) { clk_prepare_enable(bp->pclk); clk_prepare_enable(bp->hclk); clk_prepare_enable(bp->tx_clk); -- 2.20.1
Powered by blists - more mailing lists