linux-kernel - Re: [PATCH] power: supply: 88pm860x_battery: Use platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <543afc2c-d988-f0d7-1cfa-0bb7364c4486@web.de>
Date:   Fri, 3 Apr 2020 17:27:23 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tang Bin <tangbin@...s.chinamobile.com>, linux-pm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] power: supply: 88pm860x_battery: Use
 platform_get_irq_optional()

> In order to simply code,

I guess that you would like to simplify the source code a bit.

> because platform_get_irq() already has dev_err() message.

I got the impression that this information does not matter
for the change description if you would really like to call
the function “platform_get_irq_optional” at two places directly.
Will an imperative wording be more appropriate?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=bef7b2a7be28638770972ab2709adf11d601c11a#n151

Regards,
Markus