linux-kernel - Re: [PATCH] Documentation: dt-bindings: Document 'rng-seed' for /chosen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJMQK-i06+zG30tzPMgKGrrC4gcrUOcnecaBLP+uMTzfaFZu7A@mail.gmail.com>
Date:   Sat, 4 Apr 2020 00:21:13 +0800
From:   Hsin-Yi Wang <hsinyi@...omium.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Will Deacon <will@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        geert+renesas@...der.be, Stephen Boyd <swboyd@...omium.org>,
        Rob Herring <robh@...nel.org>,
        "Theodore Y. Ts'o" <tytso@....edu>
Subject: Re: [PATCH] Documentation: dt-bindings: Document 'rng-seed' for /chosen

On Fri, Apr 3, 2020 at 2:07 AM Florian Fainelli <f.fainelli@...il.com> wrote:
> >
> > Are you sure about this being limited to a u32 value? I thought you could
> > pass an arbitrary-length value here.
>
> Humm indeed, we can pass an arbitrary value, I completely conflated the
> type of "l" here:
>
>         int l;
>         ...
>         rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
>
> with how much we would be reading from the property, which is complete
> nonsense. Out of curiosity, what property length do platforms typically
> populate?
> --
> Florian

64 bytes should be able to init crng. (pass CRNG_INIT_CNT_THRESH)