linux-kernel - Re: [PATCH] arm: dma-mapping: Remove unneeded NULL checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C1RPNOAB4OIV.1TTN7HLN0EYD@lenovo-laptop>
Date:   Fri, 03 Apr 2020 17:25:06 +0100
From:   "Alex Dewar" <alex.dewar@....co.uk>
To:     "Alex Dewar" <alex.dewar@....co.uk>
Cc:     <alex.dewar@....co.uk>, "Russell King" <linux@...linux.org.uk>,
        "Enrico Weigelt" <info@...ux.net>,
        "Allison Randal" <allison@...utok.net>,
        "Kate Stewart" <kstewart@...uxfoundation.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm: dma-mapping: Remove unneeded NULL checks

On Fri Mar 27, 2020 at 4:29 PM, Alex Dewar wrote:
> dma_pool_destroy() already checks for NULL arguments, so the extra check
> is unnecessary.
>
> 
> Signed-off-by: Alex Dewar <alex.dewar@....co.uk>

Gentle ping?
> ---
> arch/arm/common/dmabounce.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> 
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index f4b719bde763..a7c776cdc38f 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -560,10 +560,8 @@ void dmabounce_unregister_dev(struct device *dev)
> BUG();
> }
>
> 
> - if (device_info->small.pool)
> - dma_pool_destroy(device_info->small.pool);
> - if (device_info->large.pool)
> - dma_pool_destroy(device_info->large.pool);
> + dma_pool_destroy(device_info->small.pool);
> + dma_pool_destroy(device_info->large.pool);
>
> 
> #ifdef STATS
> if (device_info->attr_res == 0)
> --
> 2.26.0
>
> 
>
> 
>
>