linux-kernel - RE: [PATCH v4 08/25] ocxl: Emit a log message showing how much LPC memory was detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Apr 2020 14:52:42 +1100
From:   "Alastair D'Silva" <alastair@...ilva.org>
To:     "'Dan Williams'" <dan.j.williams@...el.com>
Cc:     "'Aneesh Kumar K . V'" <aneesh.kumar@...ux.ibm.com>,
        "'Oliver O'Halloran'" <oohall@...il.com>,
        "'Benjamin Herrenschmidt'" <benh@...nel.crashing.org>,
        "'Paul Mackerras'" <paulus@...ba.org>,
        "'Michael Ellerman'" <mpe@...erman.id.au>,
        "'Frederic Barrat'" <fbarrat@...ux.ibm.com>,
        "'Andrew Donnellan'" <ajd@...ux.ibm.com>,
        "'Arnd Bergmann'" <arnd@...db.de>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Vishal Verma'" <vishal.l.verma@...el.com>,
        "'Dave Jiang'" <dave.jiang@...el.com>,
        "'Ira Weiny'" <ira.weiny@...el.com>,
        "'Andrew Morton'" <akpm@...ux-foundation.org>,
        "'Mauro Carvalho Chehab'" <mchehab+samsung@...nel.org>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Rob Herring'" <robh@...nel.org>,
        "'Anton Blanchard'" <anton@...abs.org>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Mahesh Salgaonkar'" <mahesh@...ux.vnet.ibm.com>,
        "'Madhavan Srinivasan'" <maddy@...ux.vnet.ibm.com>,
        "'Cédric Le Goater'" <clg@...d.org>,
        "'Anju T Sudhakar'" <anju@...ux.vnet.ibm.com>,
        "'Hari Bathini'" <hbathini@...ux.ibm.com>,
        "'Thomas Gleixner'" <tglx@...utronix.de>,
        "'Greg Kurz'" <groug@...d.org>,
        "'Nicholas Piggin'" <npiggin@...il.com>,
        "'Masahiro Yamada'" <yamada.masahiro@...ionext.com>,
        "'Alexey Kardashevskiy'" <aik@...abs.ru>,
        "'Linux Kernel Mailing List'" <linux-kernel@...r.kernel.org>,
        "'linuxppc-dev'" <linuxppc-dev@...ts.ozlabs.org>,
        "'linux-nvdimm'" <linux-nvdimm@...ts.01.org>,
        "'Linux MM'" <linux-mm@...ck.org>
Subject: RE: [PATCH v4 08/25] ocxl: Emit a log message showing how much LPC memory was detected

> -----Original Message-----
> From: Dan Williams <dan.j.williams@...el.com>
> Sent: Wednesday, 1 April 2020 7:49 PM
> To: Alastair D'Silva <alastair@...ilva.org>
> Cc: Aneesh Kumar K . V <aneesh.kumar@...ux.ibm.com>; Oliver O'Halloran
> <oohall@...il.com>; Benjamin Herrenschmidt
> <benh@...nel.crashing.org>; Paul Mackerras <paulus@...ba.org>; Michael
> Ellerman <mpe@...erman.id.au>; Frederic Barrat <fbarrat@...ux.ibm.com>;
> Andrew Donnellan <ajd@...ux.ibm.com>; Arnd Bergmann
> <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>;
> Vishal Verma <vishal.l.verma@...el.com>; Dave Jiang
> <dave.jiang@...el.com>; Ira Weiny <ira.weiny@...el.com>; Andrew Morton
> <akpm@...ux-foundation.org>; Mauro Carvalho Chehab
> <mchehab+samsung@...nel.org>; David S. Miller <davem@...emloft.net>;
> Rob Herring <robh@...nel.org>; Anton Blanchard <anton@...abs.org>;
> Krzysztof Kozlowski <krzk@...nel.org>; Mahesh Salgaonkar
> <mahesh@...ux.vnet.ibm.com>; Madhavan Srinivasan
> <maddy@...ux.vnet.ibm.com>; Cédric Le Goater <clg@...d.org>; Anju T
> Sudhakar <anju@...ux.vnet.ibm.com>; Hari Bathini
> <hbathini@...ux.ibm.com>; Thomas Gleixner <tglx@...utronix.de>; Greg
> Kurz <groug@...d.org>; Nicholas Piggin <npiggin@...il.com>; Masahiro
> Yamada <yamada.masahiro@...ionext.com>; Alexey Kardashevskiy
> <aik@...abs.ru>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>;
> linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>; linux-nvdimm <linux-
> nvdimm@...ts.01.org>; Linux MM <linux-mm@...ck.org>
> Subject: Re: [PATCH v4 08/25] ocxl: Emit a log message showing how much
> LPC memory was detected
> 
> On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva <alastair@...ilva.org>
> wrote:
> >
> > This patch emits a message showing how much LPC memory & special
> > purpose memory was detected on an OCXL device.
> >
> > Signed-off-by: Alastair D'Silva <alastair@...ilva.org>
> > Acked-by: Frederic Barrat <fbarrat@...ux.ibm.com>
> > Acked-by: Andrew Donnellan <ajd@...ux.ibm.com>
> > ---
> >  drivers/misc/ocxl/config.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
> > index a62e3d7db2bf..69cca341d446 100644
> > --- a/drivers/misc/ocxl/config.c
> > +++ b/drivers/misc/ocxl/config.c
> > @@ -568,6 +568,10 @@ static int read_afu_lpc_memory_info(struct
> pci_dev *dev,
> >                 afu->special_purpose_mem_size =
> >                         total_mem_size - lpc_mem_size;
> >         }
> > +
> > +       dev_info(&dev->dev, "Probed LPC memory of %#llx bytes and special
> purpose memory of %#llx bytes\n",
> > +                afu->lpc_mem_size, afu->special_purpose_mem_size);
> 
> A patch for a single log message is too fine grained for my taste, let's squash
> this into another patch in the series.
> 

I'm not sure there's a great place for it. At a pinch, it could with the previous patch, but they are really different layers.

> > +
> >         return 0;
> >  }
> >
> > --
> > 2.24.1
> >
> 
> 
> --
> This email has been checked for viruses by AVG.
> https://www.avg.com